commit 4aabd0ba50714a21da56edc5d74af3051a0e68c7 (HEAD)
Author: Scott Moser <smoser@brickies.net>
Date:   Thu Jun 8 14:15:00 2017 -0400

    smoser changes

diff --git a/tools/run-centos b/tools/run-centos
index 9ca2c67e..9cc2c9c1 100755
--- a/tools/run-centos
+++ b/tools/run-centos
@@ -1,15 +1,16 @@
 #!/bin/bash
 # This file is part of cloud-init. See LICENSE file for license information.
 
-set -ux
+set -u
 
 VERBOSITY=0
 TEMP_D=""
+KEEP=false
+CONTAINER=""
 
 error() { echo "$@" 1>&2; }
-errorp() { printf "$@" 1>&2; }
 fail() { [ $# -eq 0 ] || error "$@"; exit 1; }
-failp() { [ $# -eq 0 ] || errorp "$@"; exit 1; }
+errorrc() { local r=$?; error "$@" "ret=$r"; return $r; }
 
 Usage() {
     cat <<EOF
@@ -29,10 +30,9 @@ EOF
 
 bad_Usage() { Usage 1>&2; [ $# -eq 0 ] || error "$@"; return 1; }
 cleanup() {
-    if [ ! -n "$keep" ]; then
-        delete_container
+    if [ -n "$CONTAINER" -a "$KEEP" = "false" ]; then
+        delete_container "$CONTAINER"
     fi
-
     [ -z "${TEMP_D}" -o ! -d "${TEMP_D}" ] || rm -Rf "${TEMP_D}"
 }
 
@@ -42,54 +42,79 @@ debug() {
     error "${@}"
 }
 
+
+inside_as() {
+    local name="$1" user="$2"
+    shift 2
+    if [ $# -gt 1 ]; then
+        error "inside_as only can take one arg. sorry."
+        return 1
+    fi
+    inside "$name" su "$user" -c "$1"
+}
+
+inside() {
+    local name="$1"
+    shift
+    lxc exec "$name" -- "$@"
+}
+
 inject_cloud_init(){
+    local name="$1"
     tarball_name='cloud-init.tar.gz'
-    top_d=$(git rev-parse --show-toplevel) || 
+    top_d=$(git rev-parse --show-toplevel) ||
         fail "failed to get top level"
-    cd "$top_d" || 
+    cd "$top_d" ||
         fail "failed to cd to git top dir"
     tar_folder=${PWD##*/}
     cd ..
-    tar -czf "$TEMP_D/$tarball_name" "$tar_folder" || 
+    tar -czf "$TEMP_D/$tarball_name" "$tar_folder" ||
         fail "failed: creating tarball_name"
     cd "$tar_folder" ||
         fail "failed: changing directory"
 
     user='centos'
     tarball="/home/$user/$tarball_name"
-    lxc exec "$name" -- useradd "$user"
+    inside "$name" useradd "$user"
     lxc file push "$TEMP_D/$tarball_name" "$name/home/$user"/
-    lxc exec "$name" -- chown "$user:$user" "$tarball"
-    lxc exec "$name" -- su "$user" -c "tar -C /home/$user -xzf $tarball" ||
+    inside "$name" chown "$user:$user" "$tarball"
+    inside_as "$name" "$user" "tar -C /home/$user -xzf $tarball" ||
         fail "failed: extracting tarball"
 }
 
 start_container() {
-    name=cloud-init-centos-$(uuidgen -t | cut -c1-8)
-    lxc launch images:centos/"$version" "$name"
-
-    for i in {1..20}
-    do
-        lxc exec "$name" -- getent hosts mirrorlist.centos.org
-        rc=$?
-        if [ "$rc" == "0" ]; then
-            break
-        fi
-        sleep 5
-    done
-
-    if [ ! -z "${http_proxy-}" ]; then
-        lxc exec "$name" -- sh -c "echo proxy=$http_proxy >> /etc/yum.conf"
+    local src="$1" name="$2"
+    debug 1 "starting container $name from '$src'"
+    lxc launch "$src" "$name" || {
+        errorrc "Failed to start container '$name' from '$src'";
+        return
+    }
+    CONTAINER=$name
+
+    local out="" ret=""
+    debug 1 "waiting for networking"
+    out=$(inside "$name" sh -c '
+        i=0
+        while [ $i -lt 60 ]; do
+            getent hosts mirrorlist.centos.org && exit 0
+            sleep 2
+        done' 2>&1)
+    ret=$?
+    if [ $ret -ne 0 ]; then
+        error "Waiting for network in container '$name' failed. [$ret]"
+        error "$out"
+        return $ret
     fi
 
-    # CentOS 6 does not come with tar
-    if [[ "$version" -eq "6" ]]; then
-        lxc exec "$name" -- yum install --assumeyes tar
+    if [ ! -z "${http_proxy-}" ]; then
+        debug 1 "configuring proxy ${http_proxy}"
+        inside "$name" sh -c "echo proxy=$http_proxy >> /etc/yum.conf"
     fi
 }
 
 delete_container() {
-    lxc delete --force "$name"
+    debug 1 "removing container $1 [--keep to keep]"
+    lxc delete --force "$1"
 }
 
 main() {
@@ -105,11 +130,11 @@ main() {
     local artifact="" keep="" rpm="" srpm="" unittest="" version=""
 
     while [ $# -ne 0 ]; do
-        cur="$1"; next="$2";
+        cur="${1:-}"; next="${2:-}";
         case "$cur" in
             -a|--artifact) artifact=1;;
             -h|--help) Usage ; exit 0;;
-            -k|--keep) keep=1;;
+            -k|--keep) KEEP=true;;
             -r|--rpm) rpm=1;;
             -s|--srpm) srpm=1;;
             -u|--unittest) unittest=1;;
@@ -127,34 +152,50 @@ main() {
     trap cleanup EXIT
 
     # program starts here
-    start_container
-    inject_cloud_init
+    local uuid="" name=""
+    uuid=$(uuidgen -t) || { error "no uuidgen"; return 1; }
+    name="cloud-init-centos-${uuid%%-*}"
+
+    start_container "images:centos/$version" "$name"
+    # CentOS 6 does not come with tar
+    if [ "$version" = "6" ]; then
+        inside "$name" yum install --assumeyes tar || {
+            errorrc "FAIL: yum install tar failed";
+        }
+    fi
+
+    debug 1 "inserting cloud-init"
+    inject_cloud_init "$name" || {
+        errorrc "FAIL: injecting cloud-init into $name failed."
+        return
+    }
 
     # install dependencies
-    lxc exec "$name" -- /bin/sh <tools/setup-centos ||
+    debug 1 "installing dependencies"
+    inside "$name" /bin/sh <tools/setup-centos ||
         fail "failed: setting up container $name"
 
-    rc=0
-	if [ -n "$unittest" ]; then
-        lxc exec "$name" -- su "$user" -c \
-            "cd /home/$user/$tar_folder; nosetests tests/unittests"
-        rc=$((rc+$?))
-	fi
+    local errors=0 do_cd="cd /home/$user/$tar_folder"
+    inside_as "$name" "$user" "$do_cd; git checkout .; git status" ||
+            { errorrc "git checkout failed."; errors=$(($errors+1)); }
 
-    lxc exec "$name" -- su "$user" -c \
-        "cd /home/$user/$tar_folder; git checkout .; git status"
+    if [ -n "$unittest" ]; then
+        debug 1 "running unit tests."
+        inside_as "$name" "$user" "$do_cd; nosetests tests/unittests" ||
+            { errorrc "nosetests failed."; errors=$(($errors+1)); }
+    fi
 
-	if [ -n "$srpm" ]; then
-        lxc exec "$name" -- su "$user" -c \
-            "cd /home/$user/$tar_folder; ./packages/brpm --srpm"
-        rc=$((rc+$?))
-	fi
+    if [ -n "$srpm" ]; then
+        debug 1 "building srpm."
+        inside_as "$name" "$user" "$do_cd; ./packages/brpm --srpm" ||
+            { errorrc "brpm --srpm."; errors=$(($errors+1)); }
+    fi
 
-	if [ -n "$rpm" ]; then
-        lxc exec "$name" -- su "$user" -c \
-            "cd /home/$user/$tar_folder; ./packages/brpm"
-        rc=$((rc+$?))
-	fi
+    if [ -n "$rpm" ]; then
+        debug 1 "building rpm."
+        inside_as "$name" "$user" "$do_cd; ./packages/brpm" ||
+            { errorrc "brpm failed."; errors=$(($errors+1)); }
+    fi
 
     if [ -n "$artifact" ]; then
         cmd="ls /home/$user/$tar_folder/*.rpm"
@@ -163,8 +204,12 @@ main() {
         done
     fi
 
-    exit "$rc"
+    if [ "$errors" != "0" ]; then
+        error "there were $errors errors."
+        return 1
+    fi
+    return 0
 }
 
 main "$@"
-# vi: ts=4 noexpandtab
+# vi: ts=4 expandtab